Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behavior difference in removing a link #20

Open
liusida opened this issue Jun 5, 2024 · 2 comments
Open

Behavior difference in removing a link #20

liusida opened this issue Jun 5, 2024 · 2 comments

Comments

@liusida
Copy link

liusida commented Jun 5, 2024

If the user drag the end of the link from the input slot of the next node out (I usually remove links this way), the behavior is different from the original repo.

Original LiteGraph.js:

Screenshot 2024-06-05 193713

Here:

Screenshot 2024-06-05 193816

@liusida
Copy link
Author

liusida commented Jun 5, 2024

Also, clicking the middle point of a link produces a javascript error:

[Uncaught](lgraphcanvas.js:5621 Uncaught)
ReferenceError: options is not defined

@atlasan
Copy link
Collaborator

atlasan commented Jun 8, 2024

There is a LiteGraph property controlling the link behavior:
LiteGraph.shift_click_do_break_link_from = false; // [false!] prefer false if too easy to break links - implement with ALT or TODO custom keys
We could move back to default and put false, that's an option each editor could set itself.
Middle click should work on forwardcompatible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants