-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report kafka lag as time unit #195
Open
davidmparrott
wants to merge
40
commits into
danielqsj:master
Choose a base branch
from
davidmparrott:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move away from go dep
Remove DEP in the list of dependencies
Update README to reflect additional functionality
Update metric exporter to report lag as unit of time
Create Grafana mixin
switch to go-kit logging
Can we have this available? |
@danielqsj if I work on making this mergeable, is there any chance we can merge it? |
@gaantunes Yeah, I'm open for this feature. |
Cool, thanks. Will look into this in the following days and get back to you. Will need to open a PR from another repo since I don't have access to this one. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exporter will now, additionally, report a metric for kafka consumer lag as a unit of time.
Created additional function in collect to perform lag estimation
Information about current produced offsets is added during consumer group metric collection
Interpolation table is now separate file containing relevant struct and methods
Prune added, which can be called at any time to iterate of the interpolation table and remove stale and overly large data
Added ticker to perform pruning at a configurable interval
Prometheus mixin (dashboard only)