Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What to do with HTTAnalysisTools #63

Open
rcl11 opened this issue Jun 23, 2015 · 2 comments
Open

What to do with HTTAnalysisTools #63

rcl11 opened this issue Jun 23, 2015 · 2 comments

Comments

@rcl11
Copy link
Collaborator

rcl11 commented Jun 23, 2015

This concerns @adewit and @ajgilbert - so far we have kept HTTSequence capable of running the paper2013 strategy to produce flat trees in sync with those we made for the run1 analyses. However, it is potentially more complicated to keep the flat tree reading code (i.e. HTTAnalysisTools linking up with HiggsTauTauPlot4) compatible with both old and new strategies. Background methods and aliases are coded very specifically for the run 1 selections (using the "method") quantity, and HTTAnalysisTools is already 1700 lines long - do we want to try to keep both strategies available in this part of the code? Of course if we don't then we cannot remake 8 TeV datacards without using an old branch. If we are to keep both then I expect defining a new set of "method"s would probably be the simplest. Thoughts?

@ajgilbert
Copy link
Collaborator

it's a good point that HTTAnalysisTools is already quite long. it was developed fairly late on in the rush for the publication and a lot of stuff was thrown in there that probably could have been done in a better way. if it was just up to me i would start a new class now, take the best parts from the existing one and work on the things that need improving. Ditto for HiggsTauTauPlot4 and the datacard script. And for the new system i wouldn't bother trying to accommodate the format of the old ntuples

@rcl11
Copy link
Collaborator Author

rcl11 commented Jun 29, 2015

I won't close this just yet since we can hope we might have time to do something better here at a later date, but see #64 for the current solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants