Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

Gocial Dispatcher overflow #14

Open
j-forster opened this issue Sep 2, 2019 · 1 comment
Open

Gocial Dispatcher overflow #14

j-forster opened this issue Sep 2, 2019 · 1 comment

Comments

@j-forster
Copy link

When creating a new Gocial at gocialite.go#L32 , the instance is put into the Dispatchers Gocial map at gocialite.go#L37.

The instance is only freed at Dispatcher.Handle which is done in the callbackHandler (see Readme).
If the callbackHandler is not called (if the user closes the tab or the browser or simply navigates back) the Gocial instance is never freed and will result in a memory overflow.

If done on purpose, this bug will crash the golang server. It's a serious security issue.

@mar1n3r0
Copy link

Bump that's certainly an issue and seems related to: #8

Being able to store and retrieve the state from a persistence layer seems like the logical way to solve the problem as we don't want to keep that in-memory throughout the whole flow.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants