From 899a0f16b44898b73a04cc6975df66e11ee2a174 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Joakim=20S=C3=B8rensen?= Date: Thu, 10 Oct 2019 09:49:48 +0200 Subject: [PATCH 1/2] Remove wrong values (#83) * Update hacs.json * Update hacs.json --- hacs.json | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hacs.json b/hacs.json index 6cec7e9..0136a23 100644 --- a/hacs.json +++ b/hacs.json @@ -1,6 +1,4 @@ { "name": "Entity Controller", - "content_in_root": true, - "filename": "custom_components/entity_controller/__init__.py", "homeassistant": "0.90.1" -} \ No newline at end of file +} From 25f0a722a1359a649f8d531ad0b820bc806e75ac Mon Sep 17 00:00:00 2001 From: Daniel Mason Date: Thu, 10 Oct 2019 16:02:41 +0800 Subject: [PATCH 2/2] fix: pull request template and HACS manifest --- .github/PULL_REQUEST_TEMPLATE.md | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 0d6ffff..4e21364 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,7 +1,4 @@ -## React Boilerplate - -Thank you for contributing! Please take a moment to review our **contributing guidelines** -to make the process easy and effective for everyone involved. +Thank you for contributing! **Please open an issue** before embarking on any significant pull request, especially those that add a new library or change existing tests, otherwise you risk spending a lot of time working @@ -9,12 +6,8 @@ on something that might not end up being merged into the project. Before opening a pull request, please ensure: -- [ ] You have followed our **contributing guidelines** - [ ] Double-check your branch is based on `dev` and targets `dev` -- [ ] Pull request has tests (we are going for 100% coverage!) -- [ ] Code is well-commented, linted and follows project conventions -- [ ] Documentation is updated (if necessary) -- [ ] Internal code generators and templates are updated (if necessary) +- [ ] Documentation is updated (VERY IMPORTANT, undocumented features cannot be discovered and used!) - [ ] Description explains the issue/use-case resolved and auto-closes related issues Be kind to code reviewers, please try to keep pull requests as small and focused as possible :)