Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traffic light related stop_line are generated in incorrect positions #99

Open
meua opened this issue Aug 3, 2023 · 14 comments
Open

Traffic light related stop_line are generated in incorrect positions #99

meua opened this issue Aug 3, 2023 · 14 comments
Labels
bug Something isn't working P1

Comments

@meua
Copy link

meua commented Aug 3, 2023

Excuse me, the stop line is in the wrong place, and the generated map file is missing lane_overlap_info.start_s and lane_overlap_info.end_s
The position of the stop_line is offset as follow:
b307bc9a0f6ef2665408879e054e90bb
The position of the decision fence is shifted as follow:
2d7e557ec2c60fa4883c3a15d40c0eba
Use imap to convert Town01.xodr of Carla0.9.14 to apollo map, The location of the above apollo screenshot corresponds to the following location of the Town01.xodr file
image

@daohu527
Copy link
Owner

daohu527 commented Aug 4, 2023

What do you mean by the stop line error, the stop line is about 1m behind the zebra crossing. I don't understand what is the error?

@meua
Copy link
Author

meua commented Aug 4, 2023

What do you mean by the stop line error, the stop line is about 1m behind the zebra crossing. I don't understand what is the error?as shown in the green box:

I saw in the picture that the stop line ran to the sidewalk. I don’t know if I understand it correctly. as shown in the green box:
image

@meua
Copy link
Author

meua commented Aug 4, 2023

What do you mean by the stop line error, the stop line is about 1m behind the zebra crossing. I don't understand what is the error?as shown in the green box:

I saw in the picture that the stop line ran to the sidewalk. I don’t know if I understand it correctly. as shown in the green box: image

Also stop_line of some lane are missing. The following figure is Town01.xodr rendered by carla (carla 0.9.14 comes with a map):
1184c0dd17ec2eb45d95dec3d4f18f2c

@meua
Copy link
Author

meua commented Aug 4, 2023

imap_carla_town_01.zip
Here is my generated map by imap.

@daohu527
Copy link
Owner

daohu527 commented Aug 6, 2023

@meua
Copy link
Author

meua commented Aug 6, 2023

fixed 99-traffic-light-related-stop_line-are-generated-in-incorrect-positions

Thank you very much for your support. Traffic light related stop_line are generated in correct positions. This is a very nice function implementation. The stop line is still a little flawed. Some stop lines are not generated as expected, I will continue to try to locate and fix this problem, thank you very much. as shown in the green box in the following figure, :
da440d45ad11c5ca49d47c56fd131076
The actual position in carla is as follows:
05ff6428e11cf4c28a502af12ca8fde6
The example is in the area shown in the green box below in the Town01.xodr map:
9cd18721f6ffb9caa71a753459826357

@daohu527
Copy link
Owner

daohu527 commented Aug 6, 2023

Looks like only one side is missing. This is because the right side of the road is the last section, while the left side is the first, and only the right side added.

I updated the code, but I'm not sure if the traffic lights are connected correctly, at least the stop line should be displayed normally now.

@meua
Copy link
Author

meua commented Aug 6, 2023

Looks like only one side is missing. This is because the right side of the road is the last section, while the left side is the first, and only the right side added.

I updated the code, but I'm not sure if the traffic lights are connected correctly, at least the stop line should be displayed normally now.

OK, pretty cool. I'll run again tomorrow and have a look. Thank you so much.

@meua
Copy link
Author

meua commented Aug 7, 2023

@daohu527 Excuse me, the code submitted at the end seems to have some minor logic problems, I try to adjust this part normally.
19314435ea3993af2cfcdd679546a6a5

@daohu527
Copy link
Owner

daohu527 commented Aug 7, 2023

I know the problem, will fixed soon

@meua
Copy link
Author

meua commented Aug 7, 2023

I know the problem, will fixed soon

Great, looking forward to seeing your fix.

@daohu527
Copy link
Owner

daohu527 commented Aug 7, 2023

Updated, but I'm not so sure about traffic lights overlaps

@meua
Copy link
Author

meua commented Aug 7, 2023

Updated, but I'm not so sure about traffic lights overlaps

Okay, thank you for reminding, the current implementation is to process the traffic lights on the left and right sides separately. Is it necessary to calculate the is_merge field for lane overlap?

@meua
Copy link
Author

meua commented Aug 8, 2023

Updated, but I'm not so sure about traffic lights overlaps

The stop line is still flawed.
4ad6636f01ecf79f98d60cfa624be79a

@daohu527 daohu527 added bug Something isn't working P1 labels Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P1
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants