Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make DAOs search input execute less often #16

Open
dkent600 opened this issue Sep 4, 2020 · 1 comment
Open

make DAOs search input execute less often #16

dkent600 opened this issue Sep 4, 2020 · 1 comment

Comments

@dkent600
Copy link
Contributor

dkent600 commented Sep 4, 2020

Currently the DAOs search input executes a DAOs query and re-render of the page on every keypress when the input value is longer than two characters. This is often going to cause a lot of unnecessary queries and renders.

So I would like to propose that change this behavior in either of two ways:

  1. execute on enter and blur (loss of focus), or
  2. add a search button to the right of the input field, and an 'x' in the input field to clear it. Clicking either one executes.

I think my vote would be 1. This is how I'd like to implement the new proposal search input.

@dkent600 dkent600 changed the title make DAOs search input execute on Enter and blur make DAOs search input execute less often Sep 4, 2020
@orenyodfat orenyodfat transferred this issue from daostack/alchemy Nov 10, 2020
@orenyodfat
Copy link
Contributor

see daostack/alchemy#2104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants