Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indexed parameters #10

Open
pauliax opened this issue Nov 18, 2017 · 2 comments
Open

Indexed parameters #10

pauliax opened this issue Nov 18, 2017 · 2 comments

Comments

@pauliax
Copy link

pauliax commented Nov 18, 2017

Consider adding "indexed" keyword next to the event parameter. The indexed parameters allow filtering events by specific addresses. For example,
event AuctionCreated(uint256 tokenId, uint256 startingPrice, uint256 endingPrice, uint256 duration);
//make tokenId indexed
event AuctionSuccessful(uint256 tokenId, uint256 totalPrice, address winner);
//make winner indexed
event AuctionCancelled(uint256 tokenId);
//make tokenId indexed
event Pregnant(address owner, uint256 matronId, uint256 sireId);
//make owner indexed

@dete
Copy link

dete commented Nov 19, 2017

Great suggestion. Thanks @pauliax!

I think we'll add indexed to all tokenId and address instances (so Pregnant would have all three parameters indexed).

@kimcope
Copy link
Contributor

kimcope commented Nov 21, 2017

Thanks for your participation, @pauliax! Our team has reviewed your submission, and we are pleased to reward you for your report.

Impact: Low
Likelihood: Low
Points: 50

Please see the final leaderboard here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants