Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Polkadot JS Option In Iframe #448

Merged
merged 6 commits into from
Nov 6, 2023
Merged

Remove Polkadot JS Option In Iframe #448

merged 6 commits into from
Nov 6, 2023

Conversation

teodorus-nathaniel
Copy link
Contributor

@teodorus-nathaniel teodorus-nathaniel commented Nov 3, 2023

Polkadot JS related Change

Widget Improvement

  • Add new event isUpdatingConfig that have value 'true' or 'false' which will be given from grill when you call setConfig. Grill will fire that event with 'true' before its navigating to new page, and will fire event again with value 'false' after its done navigating
  • Rename event listener adder and remover function to be more generic, because now its not just for unreads event

@teodorus-nathaniel teodorus-nathaniel marked this pull request as draft November 3, 2023 14:52
@teodorus-nathaniel teodorus-nathaniel self-assigned this Nov 6, 2023
@teodorus-nathaniel teodorus-nathaniel added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Nov 6, 2023
@teodorus-nathaniel teodorus-nathaniel marked this pull request as ready for review November 6, 2023 13:32
@teodorus-nathaniel teodorus-nathaniel changed the title Grill Widget Improvement Remove Polkadot JS Option In Iframe Nov 6, 2023
@olehmell olehmell merged commit 95a9513 into main Nov 6, 2023
@teodorus-nathaniel teodorus-nathaniel deleted the improvement/widget branch November 9, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants