Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration to ensure docker aliases consistency #1402

Closed
pablomendezroyo opened this issue Mar 6, 2023 · 3 comments
Closed

Add migration to ensure docker aliases consistency #1402

pablomendezroyo opened this issue Mar 6, 2023 · 3 comments
Assignees
Labels
docker Tasks related to Docker P1 Has to be done but not urgent

Comments

@pablomendezroyo
Copy link
Contributor

Add a migration to ensure docker compose aliases consistency.
Having a package name example.dnp.dappnode.eth the aliases should be:

  • example.dappnode if the package is mono service
  • service1.example.dappnode if the package is multiservice
  • service1.example.dappnode and example.dappnode if the package is multiservice and has in manifest mainservice
@pablomendezroyo pablomendezroyo added P1 Has to be done but not urgent dock docker Tasks related to Docker and removed dock labels Mar 6, 2023
@Marketen
Copy link
Contributor

As discused today @pablomendezroyo @dsimog01 , we should change alias rules to:

  • For dnp packages ( example.dnp.dappnode.eth). Whether it's a mono or multi-service package:

    • Each service should have an alias format of <service_name>.example.dappnode.
    • If it's the main service, also include example.dappnode.
  • For public packages ( example.public.dappnode.eth). Whether it's a mono or multi-service package:

    • Each service should have an alias format of <service_name>.example.public.dappnode.
    • If it's the main service, also include example.public.dappnode.

    Is this correct?

@pablomendezroyo
Copy link
Contributor Author

@Marketen thats correct!

@pablomendezroyo
Copy link
Contributor Author

Completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Tasks related to Docker P1 Has to be done but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants