Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Canon Powershot S100 (.CR2) #695

Open
arturoisilvia opened this issue Mar 18, 2024 · 3 comments
Open

Support for Canon Powershot S100 (.CR2) #695

arturoisilvia opened this issue Mar 18, 2024 · 3 comments

Comments

@arturoisilvia
Copy link

arturoisilvia commented Mar 18, 2024

I request support for Canon Powershot S100 (.CR2) with the following parameters:
Level 0 -> 128
Level 1 -> 128
Level 2 -> 128
Level 3 -> 128
white point -> 2990

Thank you.

@arturoisilvia arturoisilvia changed the title Support for Canon Powershot S100 Support for Canon Powershot S100 (.CR2) Mar 18, 2024
@kmilos
Copy link
Collaborator

kmilos commented Mar 18, 2024

Just to clarify, this is a request to revert part of #578 for S100 only.

@LebedevRI
Copy link
Member

That change is correct, we read reasonable values from the makernotes:

whitePoint: 2976
blackLevelSeparate: (2 x 2) 128 128 128 128

what isn't however correct, is the rest of the hardcoded stuff,
because after sampling the hardcoded black areas we get:

blackLevelSeparate: (2 x 2) 65535 65535 65535 65535

Refs. #389.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@LebedevRI @kmilos @arturoisilvia and others