Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leica M10-D, M10-P and M10-R name normalisation #540

Merged
merged 3 commits into from
Oct 27, 2023

Conversation

kmilos
Copy link
Collaborator

@kmilos kmilos commented Oct 27, 2023

They keep popping up...

@kmilos kmilos requested a review from LebedevRI as a code owner October 27, 2023 13:48
@kmilos kmilos changed the title Leica M10-P and M10-R name normalisation Leica M10-D, M10-P and M10-R name normalisation Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6d7604f) 58.95% compared to head (ccfed76) 58.95%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #540   +/-   ##
========================================
  Coverage    58.95%   58.95%           
========================================
  Files          234      234           
  Lines        13940    13940           
  Branches      1943     1943           
========================================
  Hits          8219     8219           
  Misses        5588     5588           
  Partials       133      133           
Flag Coverage Δ
benchmarks 8.15% <ø> (ø)
integration 47.40% <ø> (ø)
linux 56.88% <ø> (ø)
macOS 18.62% <ø> (ø)
rpu_u 47.40% <ø> (ø)
unittests 18.17% <ø> (ø)
windows ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LebedevRI
Copy link
Member

We really should either be doing that automatically (how are these derived manually?),
or not doing it at all. It is intrinsically wrong that DNG files require such manual adjustments.

@LebedevRI LebedevRI merged commit 25a074f into darktable-org:develop Oct 27, 2023
39 checks passed
@LebedevRI
Copy link
Member

Thank you.

@kmilos kmilos deleted the kmilos/leica_m10p branch October 27, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants