Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update primitives.def #189

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jthompsonic
Copy link

@jthompsonic jthompsonic commented Jul 16, 2023

A few tweaks needed -- library produced on windows is primitives.dll so we need library name "primitives"

we need to add free_pointer to the exports so we can access that function in the primitives.dart program (get an uncaught exception when trying to run the primitives.dart program as it is now).

  • Thanks for your contribution! Please replace this text with a description of what this PR is changing or adding and why, list any relevant issues, and review the contribution guidelines below.

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

A few tweaks needed -- library produced on windows is primitives.dll so we need library name "primitives"

we need to add free_pointer to the exports so we can access that function in the primitives.dart program (get an uncaught exception when trying to run the primitives.dart program as it is now).
@google-cla
Copy link

google-cla bot commented Jul 16, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jthompsonic
Copy link
Author

I filled out the Google CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant