Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support code highlighting in markdown code blocks #1744

Closed
kwalrath opened this issue Jul 10, 2019 · 4 comments
Closed

Support code highlighting in markdown code blocks #1744

kwalrath opened this issue Jul 10, 2019 · 4 comments
Labels
co.help-wanted Community opportunity to help documentation e2-days Can complete in < 5 days of normal, not dedicated, work infra.structure Relates to the tools that create dart.dev p2-medium Necessary but not urgent concern. Resolve when possible.

Comments

@kwalrath
Copy link
Contributor

kwalrath commented Jul 10, 2019 •
edited
Loading

I’d love to be able to use only triple-tick dart, never {% prettify …%}. But at least one use case (highlighting: [!…!]) doesn’t work with triple-tick dart. Having to remember to use prettify causes unnecessary complexity for site contributors. Also, I think prettify styles are different from ```dart styles.

Second, it’d be good to improve the formatting of code within strings: #1108.
@kwalrath kwalrath added infra.structure Relates to the tools that create dart.dev p2-medium Necessary but not urgent concern. Resolve when possible. e2-days Can complete in < 5 days of normal, not dedicated, work labels Jul 10, 2019
@kwalrath kwalrath mentioned this issue Jul 10, 2019
Closed
@chalin
Copy link
Contributor

chalin commented Sep 18, 2019

It is possible to use triple-tick markdown and get highlighting to work -- that what we did in site-webdev. AFAIR, most of the necessary infrastructure has already been moved into site-shared.

@chalin
Copy link
Contributor

chalin commented Sep 18, 2019

(Maybe the title of this issue should be updated to something like: Support code highlighting in markdown code blocks.)

@chalin chalin mentioned this issue Sep 18, 2019
Closed
@kwalrath kwalrath changed the title Improve Dart code formatting Support code highlighting in markdown code blocks Sep 18, 2019
@smolck smolck mentioned this issue Oct 2, 2019
Closed
@kwalrath kwalrath mentioned this issue Dec 9, 2019
Closed
@parlough
Copy link
Member

parlough commented Nov 22, 2021 •
edited
Loading

It would be nice to standardize on markdown blocks, so if anyone wants to look into this, that would be super helpful!

@parlough parlough self-assigned this Nov 22, 2021
@parlough parlough mentioned this issue Feb 20, 2022
Closed
6 tasks
@parlough parlough removed their assignment May 4, 2022
@parlough parlough added the co.help-wanted Community opportunity to help documentation label May 4, 2022
@parlough
Copy link
Member

parlough commented Nov 7, 2022

I'm going to close this in favor of tracking the work in #3846.

@parlough parlough closed this as completed Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
co.help-wanted Community opportunity to help documentation e2-days Can complete in < 5 days of normal, not dedicated, work infra.structure Relates to the tools that create dart.dev p2-medium Necessary but not urgent concern. Resolve when possible.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kwalrath @chalin @parlough