Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code-prettify dart highlighting #1624

Merged
merged 1 commit into from
May 20, 2019

Conversation

parlough
Copy link
Member

I noticed there were a lot of old and new keywords missing or highlighted wrong on the website, so I went ahead and added everyone I found to be missing. I made this PR on the code-prettify repository as well, but it seems maintenance is quite slow over there, so I made it here as well. I'll make any requested changes in both locations and can always update again when upstream changes are made.

You can find the other PR here with some more information: googlearchive/code-prettify#592

@googlebot googlebot added the cla: yes Contributor has signed the Contributor License Agreement label May 17, 2019
@kwalrath
Copy link
Contributor

Thank you so much, @parlough! This looks great to me, but I should get a DPE to take a look, just to be sure.

@kwalrath kwalrath requested a review from johnpryan May 17, 2019 22:53
Copy link
Contributor

@johnpryan johnpryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Contributor has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants