Fix getProperties invocation passing length for all objects. #2480
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vm_service Instance spec specifies that the
length
property specifies thatlength
should be the number of non-static fields for plain objects. In order to align with the VM we've updated the DDC debugger API to include this value oflength
on plain objects.However,
getProperties
is assuming that if a length is provided then it should do a range check with the providedoffset
andcount
. This was causing thegetProperties
code to exit early with no value.To fix this we only pass the
length
togetProperties
if thekind
of the object being inspected is not a plain object. Plain objects should never need a range check.Fixes #2479.