Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make static panel with html direct inclusion #173

Open
dascritch opened this issue Apr 28, 2021 · 1 comment
Open

Make static panel with html direct inclusion #173

dascritch opened this issue Apr 28, 2021 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@dascritch
Copy link
Owner

dascritch commented Apr 28, 2021

To add some specific functions, as in example for speed or volume controls.

We may also include it in the inner of the <cpu-audio> tag, via some <div data-panel=""> tag ?

@dascritch dascritch added the good first issue Good for newcomers label Apr 28, 2021
@dascritch dascritch added this to the 7.1 milestone Apr 28, 2021
dascritch added a commit that referenced this issue Apr 29, 2021
Make static panel with html direct inclusion #173
@dascritch dascritch added the enhancement New feature or request label Sep 7, 2022
@dascritch
Copy link
Owner Author

dascritch commented Sep 26, 2022

This MAY NOT BE a good idea in security, as it may open a way to do HTML/JS injection with a really vicious way to hide it. Even if there is numerous way to do the same, we should prevent it on our side. May be via CSP directives in the shadow DOM ?
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy

But be cautionous to still permit to the host page to use external or inline JS and CSS.

@dascritch dascritch modified the milestones: 7.1, 7.2 Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant