Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change fine navigation alternative for non small pointer devices #180

Open
6 tasks
dascritch opened this issue Sep 6, 2022 · 3 comments
Open
6 tasks

Change fine navigation alternative for non small pointer devices #180

dascritch opened this issue Sep 6, 2022 · 3 comments
Labels
accessibility no one left behind doc write Need more documentation to write enhancement New feature or request question Further information is requested
Milestone

Comments

@dascritch
Copy link
Owner

dascritch commented Sep 6, 2022

The fine poisition alternative panel for big fingers is not really easy, as it is really a pain to activate it if you don't know how to do it.
I think we must bet to change the height of the component under the navigation main, it won't change too much a page, as long we can prevent display it via attributes.

Here is what I think to do ;

  • Transform fine navigation as a panel
  • Display it by default only with media-query any-pointer:coarse
  • Modify showHandheldNav() action in element_cpu.js
  • Remove old fine navigation alternative (may be the most tricky, to clean the old event code)
  • Add an attribute to add it
  • Document it
@dascritch
Copy link
Owner Author

dascritch commented Sep 6, 2022

we can do it js side with this method

window.matchMedia( '(any-pointer:fine)' ).matches returns a boolean.
It can even get events

@dascritch dascritch added this to the 7.1 milestone Sep 6, 2022
@dascritch dascritch added enhancement New feature or request good first issue Good for newcomers doc write Need more documentation to write accessibility no one left behind labels Sep 7, 2022
dascritch pushed a commit that referenced this issue Sep 26, 2022
Change fine navigation alternative for non small pointer devices #180
@dascritch
Copy link
Owner Author

dascritch commented Sep 26, 2022

May be we should add an attribute ? fineposition="auto|no|yes" ? I don't know yet
Or may be it should be a panel but a specific <details>/<summary> alike, where the "close" button is also closing itself ?
So, we will have something like × |<< <<< << >> >>> . We also may imagine a new input form to enter manually a specific moment by this way.

But getting a new panel is making the page reflowing. And if the player is in a navigation context, or at the bottom of the viewport, we risk inconsistancies.

This is a really impactful situation, I think this is a major release situation, i.e. for 8.0

@dascritch dascritch added question Further information is requested and removed good first issue Good for newcomers labels Sep 26, 2022
@dascritch dascritch modified the milestones: 7.1, 8.0 Sep 26, 2022
@dascritch
Copy link
Owner Author

Youtube introduced a new gesture on itsplayer : on the time line, swipping to the up will do appearing a more precise navigation.
A clever idea for us : disappear the title to make room for the fine position buttons. And can also be used for Tab-key navigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility no one left behind doc write Need more documentation to write enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant