Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite_layer_chains does not respect kwargs #561

Open
lgray opened this issue Dec 17, 2024 · 2 comments · May be fixed by #562
Open

rewrite_layer_chains does not respect kwargs #561

lgray opened this issue Dec 17, 2024 · 2 comments · May be fixed by #562

Comments

@lgray
Copy link
Collaborator

lgray commented Dec 17, 2024

This is only exposed in #558 since otherwise everything gets wrapped in a ArgsKwargsPackedFunction which only ever has args, once we stop doing that (because it is expensive when called many times) unless it is really needed then it becomes apparent that only args are forwarded inside rewrite_layer_chains.

@martindurant
Copy link
Collaborator

I suppose we should make a test showing this

@lgray
Copy link
Collaborator Author

lgray commented Dec 17, 2024

Presently it is manifest in the post dask 2024.12.0 code, it simply does not ask for task.kwargs, nor does it pass new kwargs to the newly made task.
The pre-_task_spec code also doesn't seem to deal with kwargs in any way, but it didn't come up in local testing of #558 since I didn't downgrade and recheck, etc.

https://github.com/dask-contrib/dask-awkward/blob/main/src/dask_awkward/lib/optimize.py#L372-L384

@lgray lgray linked a pull request Dec 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants