Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require CuPy 9.0.0+ #328

Closed
jakirkham opened this issue Aug 1, 2023 · 4 comments
Closed

Require CuPy 9.0.0+ #328

jakirkham opened this issue Aug 1, 2023 · 4 comments

Comments

@jakirkham
Copy link
Member

At this point CuPy 9.0.0 has what we need as discussed in PR ( #325 )

Perhaps we should update requirements and importorskip lines to match

@m-albert
Copy link
Collaborator

m-albert commented Aug 1, 2023

Thoughts:

  1. importorskip: Currently the importorskip lines indicate the min version required for the specific functionality they're associated to. Would it be preferable to have them pinned to 9.0.0 generally?

  2. requirements: In my current understanding the only place we're indicating information about CuPy versions is in the release notes in HISTORY.rst since cupy is not a dependency.

@jakirkham
Copy link
Member Author

On 2, we might want to make add cupy as an optional dependency with a version constraint. This is partially motivated by simply documenting what we intend to support (though it may also act as an installation convenience)

@m-albert
Copy link
Collaborator

m-albert commented Aug 2, 2023

Great idea. To have it linked here, @GenevieveBuckley is incorporating cupy as an optional dependency into the pyproject.toml #306

@GenevieveBuckley
Copy link
Collaborator

Closed by https://github.com/dask/dask-image/pull/306/files
See:

"cupy >=9.0.0",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants