Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dask-kubernetes to a newer kr8s #853

Closed
jacobtomlinson opened this issue Jan 5, 2024 · 4 comments · Fixed by #880
Closed

Update dask-kubernetes to a newer kr8s #853

jacobtomlinson opened this issue Jan 5, 2024 · 4 comments · Fixed by #880

Comments

@jacobtomlinson
Copy link
Member

Recently we unpinned kr8s but things broke, so the pin was set back to 0.9.0. We need to manually update the pin to something more recent (and in theory more stable) before unpinning again.

@dbalabka
Copy link
Contributor

dbalabka commented Feb 6, 2024

@jacobtomlinson , could you please specify what exactly has been broken? Is it related to #848, or are there any other tickets?

@jacobtomlinson
Copy link
Member Author

@dbalabka I think box was the biggest change, but there was also a lot of shifting around in the port-forwarding code so we may need to do some more testing there.

@dbalabka
Copy link
Contributor

@jacobtomlinson , I noticed the changes in the port forwarding. As far I understood, dask-kubernetes uses a new way to forward ports. I tested it and it fixes the problem with websockets for us. Therefore, we don't need to use NodePort any more.

@dbalabka
Copy link
Contributor

@jacobtomlinson I will perform more tests and give a feedback in #805

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants