decompress pickled messages #8216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rerun tests |
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 21 files ± 0 21 suites ±0 10h 18m 58s ⏱️ - 10m 31s For more details on these failures, see this check. Results for commit a051bdd. ± Comparison against base commit a74f7cf. ♻️ This comment has been updated with latest results. |
pentschev
approved these changes
Sep 27, 2023
wence-
added a commit
to wence-/dask-cuda
that referenced
this pull request
Sep 27, 2023
In versions of distributed after dask/distributed#8067 but before dask/distributed#8216, we must patch protocol.loads to include the same decompression fix.
rapids-bot bot
pushed a commit
to rapidsai/dask-cuda
that referenced
this pull request
Sep 27, 2023
In versions of distributed after dask/distributed#8067 but before dask/distributed#8216, we must patch protocol.loads to include the same decompression fix. Authors: - Lawrence Mitchell (https://github.com/wence-) Approvers: - Peter Andreas Entschev (https://github.com/pentschev) URL: #1247
4 tasks
|
Thanks @madsbk @crusaderky |
pentschev
added a commit
to pentschev/dask-cuda
that referenced
this pull request
Oct 4, 2023
This change was introduced in rapidsai#1247 to include the fix from dask/distributed#8216 for the Dask-CUDA 23.10 which pinned to Distributed 2023.9.2. Starting from Distributed 2023.9.3, the fix is merged in Distributed and this isn't required anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes rapidsai/dask-cuda#1246
Make sure to decompress pickled messages when communicating. Currently, we don't decompress out-of-band buffers when using pickle!
pre-commit run --all-files