Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listen() does not work on OptionController more than once #212

Open
gvdvenis opened this issue Mar 8, 2019 · 1 comment
Open

Listen() does not work on OptionController more than once #212

gvdvenis opened this issue Mar 8, 2019 · 1 comment
Labels

Comments

@gvdvenis
Copy link

gvdvenis commented Mar 8, 2019

Just found out that this line below is breaking the listen() method on the OptionController

Try changing the value of the items in an attached array and notice that the control doesn't update its value. After commenting out this line everything works as expected

if (dom.isActive(this.__select)) return this; // prevent number from updating if user is trying to manually update

@donmccurdy donmccurdy added the bug label Mar 21, 2019
@MacroMan
Copy link
Contributor

MacroMan commented Apr 8, 2019

A tricky one, since not updating an active option input would usually be desirable.

Pull request #224 addresses this issue, by passing true into listen(true), thereby forcing updateDisplay to bypass the active check. Also in my fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants