Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal Changes
API Changes:
ServicePrincipalClientId
field for apps.App.AzureServicePrincipal
,GcpServiceAccountKey
andReadOnly
fields for catalog.CreateCredentialRequest.AzureServicePrincipal
,ReadOnly
andUsedForManagedStorage
fields for catalog.CredentialInfo.AzureServicePrincipal
andReadOnly
fields for catalog.UpdateCredentialRequest.ExternalLocationName
,ReadOnly
andUrl
fields for catalog.ValidateCredentialRequest.IsDir
field for catalog.ValidateCredentialResponse.CreateCredential
andGenerateTemporaryServiceCredential
methods for w.Credentials workspace-level service with new required argument order.AccessConnectorId
field for catalog.AzureManagedIdentity to be required.AccessConnectorId
field for catalog.AzureManagedIdentity to be required.Name
field for catalog.CreateCredentialRequest to be required.CredentialName
field for catalog.GenerateTemporaryServiceCredentialRequest to be required.OpenAPI SHA: f2385add116e3716c8a90a0b68e204deb40f996c, Date: 2024-11-15