Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECH DEBT] Update Dashboard.create_dashboard signature to match the LakeviewAPI.create/update signatures #322

Open
JCZuurmond opened this issue Nov 15, 2024 · 0 comments

Comments

@JCZuurmond
Copy link
Member

The Python SDK v0.37.0 updated the LakeviewAPI.create/update signature to expect a Dashboard object. We can update our lsql Dashboard.create_dashboard with similar changes:

def create_dashboard(
self,
dashboard_metadata: DashboardMetadata,
*,
parent_path: str | None = None,
dashboard_id: str | None = None,
warehouse_id: str | None = None,
publish: bool = False,
) -> SDKDashboard:

becomes:

    def create_dashboard(
        self,
        dashboard_metadata: DashboardMetadata,
        *,
        dashboard: SDKDashboard=None,
        publish: bool = False,
    ) -> SDKDashboard:

Use deprecation warnings to incrementally introduce this signature change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant