Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asofJoin() requires name of timpestamp column names to match #390

Open
ghormann opened this issue Mar 3, 2024 · 1 comment
Open

asofJoin() requires name of timpestamp column names to match #390

ghormann opened this issue Mar 3, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@ghormann
Copy link

ghormann commented Mar 3, 2024

When trying to use asofJoin() on two TSDF records with different time series column names an exception is raised. I'm not sure if this is a considered a bug or a feature, but given that TSDF knows the column name of each TSDF object, it seems like it should be smart enough to execute the join.

Example

  • tsdf_state has time column 'ts'
  • tsdf_validate has time column 'EndTime'
  • Running asofJoin() results in an error as it is using EndTime on tsdf_state

image

Workaround

If I make sure the time column is the same for both TSDF records it appears to work as expected. (Here column 'ts' is created as a copy of EndTime before creating tsdf_validate).

image

@tnixon tnixon added the bug Something isn't working label Mar 7, 2024
@tnixon
Copy link
Contributor

tnixon commented Mar 7, 2024

Thanks for raising this to us, @ghormann - definitely a frustrating issue. I believe this should be fixed in the upcoming v0.2 version, but we'll be sure to double check. Maybe it makes sense to get a quick fix in here before that comes out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants