Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_property_values should have a setting for no limit #76

Open
lukesmurray opened this issue Aug 8, 2019 · 0 comments
Open

get_property_values should have a setting for no limit #76

lukesmurray opened this issue Aug 8, 2019 · 0 comments
Labels
python api feedback Feedback for the Python Client API

Comments

@lukesmurray
Copy link
Contributor

lukesmurray commented Aug 8, 2019

There is no way to set the parameter limit in get_property_values so that all property values are returned. I came across this issue when I was trying to get schools from school districts. I have a list of all the school districts in New York City and I want to get all the schools in those school districts.

dc.get_property_values(pd.Series(school_district), 'schoolDistrict', False)

If this call returns 100 schools I have no way of knowing if there are more than 100 schools without issuing the call again with a higher number as the limit.

Other libraries allow for limits to be eliminated using a setting of -1.

@antaresc antaresc added the python api feedback Feedback for the Python Client API label Aug 9, 2019
@beets beets added this to the API release v1.0.1 milestone Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python api feedback Feedback for the Python Client API
Projects
None yet
Development

No branches or pull requests

3 participants