Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source files should be in its own directory #202

Open
enjoythecode opened this issue Feb 17, 2022 · 0 comments
Open

Source files should be in its own directory #202

enjoythecode opened this issue Feb 17, 2022 · 0 comments

Comments

@enjoythecode
Copy link

enjoythecode commented Feb 17, 2022

Issue

The markdown files that are used to build the documentation is at the top-level directory of this repository. This is an issue because non-documentation .md files also get built into production.

For example, the README of this repository is served at this link, which seems unintentional. LICENSE is also affected.

Also, since the source files are mixed with repository files in the top-level directory, it is hard to scan the contents and look for the file one is interested in!

Current Solution

Normally, pages that are not intended to be deployed are added to _config.yml under exclude. (see #140 )

However, this process is prone to human-errors (as evidenced by the README and LICENSE being exposed). They require manual upkeep to make sure the list is up-to-date, etc.

Proposed Change

I'd like to move all source files to its dedicated directory, perhaps called src or source. Then, jekyll configuration can be changed in one line to look at that directory for files to build. This Jekyll option is described in the official documentation.

This is a straightforward code change, and therefore it should be suitable for me as a first-time contributor.

Benefits

  1. Remove human error and effort from excluding/unpublishing irrelevant .md files to the production deployment.
  2. Better code organization, making it easier to understand the code structure and locate specific files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant