You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
into its own get_context method, which a user could override in a custom subclass of the GraphqlWsConsumer if they want to inject something into the context?
Currently I'm injecting my own fields by overriding _on_gql_start__subscribe and injecting the fields before passing it on to the super function, which seemed to be the least impactful place to do it. But I just found out that queries and mutations don't pass through that function, meaning I would have to copy-paste the entire _on_gql_start method from the source into my override class just to add my own fields to the context...
A get_context method would make this trivial and very user friendly. It would also mimic how graphene-django provides this functionality to its users:
+1 on this. Without a way to inject something into the context, I was forced to override _on_gql_start() in order to inject what I needed. I feel like having a get_context() method would be a great solution.
Would it be possible to refactor this:
DjangoChannelsGraphqlWs/channels_graphql_ws/graphql_ws_consumer.py
Lines 537 to 542 in 09a2ffd
into its own get_context method, which a user could override in a custom subclass of the GraphqlWsConsumer if they want to inject something into the context?
Currently I'm injecting my own fields by overriding
_on_gql_start__subscribe
and injecting the fields before passing it on to the super function, which seemed to be the least impactful place to do it. But I just found out that queries and mutations don't pass through that function, meaning I would have to copy-paste the entire_on_gql_start
method from the source into my override class just to add my own fields to the context...A
get_context
method would make this trivial and very user friendly. It would also mimic how graphene-django provides this functionality to its users:https://github.com/graphql-python/graphene-django/blob/e950164c8ee2a9babf54a0c2d3da27194d7cfddc/graphene_django/views.py#L139-L140
The text was updated successfully, but these errors were encountered: