Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Diffs with No Primary Key in CI #98

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions models/core/dim_orgs.sql
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@ WITH orgs AS (
--prod
SELECT
org_id
, MIN(event_timestamp) AS created_at
FROM {{ ref('signed_in') }}
GROUP BY 1
, org_name
, employee_range
, created_at
FROM {{ ref('org_created') }}

-- --dev
-- SELECT
Expand All @@ -28,7 +29,7 @@ WITH orgs AS (
org_id
, event_timestamp AS sub_created_at
, plan as sub_plan
, price as sub_price
, coalesce(price, 0) as sub_price
FROM {{ ref('subscription_created') }}
)

Expand All @@ -38,7 +39,7 @@ SELECT
, created_at
, num_users
, sub_created_at
, sub_plan
, case when num_users = 1 then 'Individual' else sub_plan end as sub_plan
, sub_price
FROM orgs
LEFT JOIN user_count USING (org_id)
Expand Down
16 changes: 8 additions & 8 deletions models/core/schema.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,21 @@ models:
- name: dim_orgs
columns:
- name: org_id
tests:
- not_null
- unique
tags: ['primary-key']
# tests:
# - not_null
# - unique
# tags: ['primary-key']
- name: fct_monthly_financials
columns:
- name: date_month
tests:
- not_null
- unique
tags: ['primary-key']
# - unique
# tags: ['primary-key']
- name: fct_yearly_financials
columns:
- name: date_year
tests:
- not_null
- unique
tags: ['primary-key']
# - unique
# tags: ['primary-key']
2 changes: 1 addition & 1 deletion models/syncs/sales_sync.sql
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ WITH org_events AS (
*
FROM {{ ref('dim_orgs') }}
LEFT JOIN {{ ref('feature_used') }} USING (org_id)
WHERE sub_plan IS NULL
WHERE sub_plan IS NULL or sub_plan = 'Individual'
)

, final AS (
Expand Down
Loading