Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datahub plugins must be installed with pydantic v1 #12108

Open
Ohad-upriver opened this issue Dec 12, 2024 · 0 comments
Open

datahub plugins must be installed with pydantic v1 #12108

Ohad-upriver opened this issue Dec 12, 2024 · 0 comments

Comments

@Ohad-upriver
Copy link

Hi,
As of this moment, when installing datahub with a plugin we must install it with pydantic v1.

In setup.py it is explain as follows:

pydantic_no_v2 = {
    # pydantic 2 makes major, backwards-incompatible changes - https://github.com/pydantic/pydantic/issues/4887
    # Tags sources that require the pydantic v2 API.
    "pydantic<2",
}

plugin_common = {
    # While pydantic v2 support is experimental, require that all plugins
    # continue to use v1. This will ensure that no ingestion recipes break.
    *pydantic_no_v2,
}

Does this mean you aren't planing to upgrade it at all?
The pydantic v2 isn't experimental anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant