Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCE/MAE Consumers start without waiting for matching versions #12138

Open
mihai103 opened this issue Dec 16, 2024 · 0 comments
Open

MCE/MAE Consumers start without waiting for matching versions #12138

mihai103 opened this issue Dec 16, 2024 · 0 comments
Labels
bug Bug report

Comments

@mihai103
Copy link

Describe the bug
The MCE and MAE consumer services in DataHub start processing messages without waiting for the version check. This can potentially lead to issues where newer versions of consumers run with older versions of GMS.

To Reproduce
Steps to reproduce the behavior:

  1. Deploy GMS, MCE and MAE as separate pods in a K8s cluster
  2. Upgrade images to new versions
  3. At this point the new GMS pod will wait for datahub-upgrade job to finish running with the corresponding version. The old GMS pod will continue running. MCE/MAE will start with the new version regardless of datahub-upgade.

Expected behavior
The expectation is that both MCE and MAE consumers will perform a version check during startup to match the version number published to the Kafka topic by datahub-upgrade.

Additional context
The bootstrapManager is not started in ApplicationStartupListener when running any consumer in standalone mode, as the context id is actually "application", which is the default for SpringBoot configured contexts, not WebApplicationContext.class.getName(). Maybe an alternative check to see if the current context is the root context would be to check if the current context has no parent, which should work in both standalone and gms only deployments.

@mihai103 mihai103 added the bug Bug report label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report
Projects
None yet
Development

No branches or pull requests

1 participant