Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simply pytests subjects_csv and sessions_csv by removing pandas dependency #157

Open
CBroz1 opened this issue Dec 30, 2021 · 1 comment
Open
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@CBroz1
Copy link
Contributor

CBroz1 commented Dec 30, 2021

I think the use of pandas here is unjustified. All the operations where it's used can be just more cleanly accomplished with python datatypes: dicts and lists.

Originally posted by @dimitri-yatsenko in datajoint/workflow-session#9 (comment)

writing a sample CSV file with sample data can be made much simpler. Consider simply writing a multiline string into a file.

Originally posted by @dimitri-yatsenko in datajoint/workflow-session#9 (comment)

@CBroz1 CBroz1 added enhancement New feature or request good first issue Good for newcomers labels Dec 30, 2021
@CBroz1 CBroz1 changed the title Integration tests cam be simplified by removing pandas dependency Integration tests subjects_csv and sessions_csv could be simplified by removing pandas dependency Dec 30, 2021
@ttngu207
Copy link
Contributor

This is reasonable, but I'm not sure about priority.
Pandas is already a dependency for DataJoint, so reimplementing this will not net us a reduction in package dependency.
For code simplification, yes, but certainly will take some time re-implementing (and copying) across the different test suites we have.

@CBroz1 CBroz1 modified the milestones: 2022Q2, 2022Q3 May 20, 2022
@kabilar kabilar changed the title Integration tests subjects_csv and sessions_csv could be simplified by removing pandas dependency Simply pytests subjects_csv and sessions_csv by removing pandas dependency Jul 15, 2022
@kabilar kabilar removed this from the 2022Q3 milestone Feb 17, 2023
@kabilar kabilar transferred this issue from datajoint/workflow-array-ephys Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants