Datamade code challenge - JP Martinez Submission #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In this PR I'm adding a submission for the Datamade Coding Challenge for the role of Developer. I was able to successfully (up to the reviewer) steps 1,2 and 5. For steps 3 and 4 I modified the html to include html tags for the error message and add
id
tags to html tags to retrieve them easier.Notes
Due to unfamiliarity with Java, and to be honest about my current technical skills I was not able to complete this sections 3 and 4 in the suggested time.
Given a high level understanding of Java, here is a brief description of the logic I would apply:
address-form
, and from the form retrieve the information for the input withname=address
an
error messageAddressParse.get()
. For the parsed components iterate over the dictionary where each elements is fitted into a row with a<tr>
tag, and then the key and value are '' tags within the<tr>
tag; these elements are included in thetable
element in thediv
with idaddress_results
. For the address_type, we insert as text_content in the<p>
tag with idparse_type
.<p>
tag with idaddress_error
the element from the response JSON associated with the error as returned inAddressParse.get()