Merge pull request #923 from jpomfret/latestBuild

Add latestbuild check
dataplat · Mar 7, 2023 · 8a6e07b · 8a6e07b
2 parents fa94622 + 33011d2
commit 8a6e07b
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/source/checks/Instancev5.Tests.ps1 b/source/checks/Instancev5.Tests.ps1
@@ -346,6 +346,15 @@ Describe "Error Log Entries" -Tag ErrorLog, Medium, Instance -ForEach $Instances
     }
 }
 
+Describe "Latest Build" -Tag LatestBuild, Security, CIS, Medium, Instance -ForEach $InstancesToTest {
+    $skip = ($__dbcconfig | Where-Object { $_.Name -eq 'skip.instance.latestbuild' }).Value
+    Context "Testing Latest Build on <_.Name>" {
+        It "The Latest Build of SQL should be installed on <_.Name>" -Skip:$skip {
+            $psitem.LatestBuild.Compliant | Should -BeTrue -Because "being patched to the latest version is important"
+        }
+    }
+}
+
 <#
 Describe "TempDB Configuration" -Tags TempDbConfiguration, Medium, Instance -ForEach $InstancesToTest {
     Context "Testing TempDB Configuration on $psitem" -Skip:(($__dbcconfig | Where-Object { $_.Name

diff --git a/source/internal/functions/NewGet-AllInstanceInfo.ps1 b/source/internal/functions/NewGet-AllInstanceInfo.ps1
@@ -270,6 +270,9 @@ function NewGet-AllInstanceInfo {
             # It is not enough to check the CreateDate on the log, you must check the LogDate on every error record as well.
             $ErrorLogCount = (Get-ErrorLogEntry | Where-Object { $psitem.LogDate -gt (Get-Date).AddDays( - $LogWindow) }).Count
         }
+        'LatestBuild' {
+            $LatestBuild = Test-DbaBuild -SqlInstance $Instance -Latest
+        }
         'TempDbConfiguration' {
             $TempDBTest = Test-DbaTempDbConfig -SqlInstance $Instance
         }
@@ -373,6 +376,9 @@ function NewGet-AllInstanceInfo {
             logWindow     = $logWindow
         }
         InstanceConnection    = $InstanceConnection
+        LatestBuild           = [PSCustomObject]@{
+            Compliant = $LatestBuild.Compliant
+        }
         # TempDbConfig          = [PSCustomObject]@{
         #     TF118EnabledCurrent     = $tempDBTest[0].CurrentSetting
         #     TF118EnabledRecommended = $tempDBTest[0].Recommended