From 6d09567e004aceae5852454b3b90e54a32cc8f2c Mon Sep 17 00:00:00 2001 From: Stephen Millet Date: Tue, 9 May 2017 17:06:59 -0400 Subject: [PATCH] Default the client timeout to None (#78) * Default the client timeout to None If we timeout on the client we do not retry. In most instances the client side timeout is not necessary and we can rely on the server side timeout and our retry mechanism. * Bumping version and adding CHANGES --- CHANGES.rst | 4 ++++ datarobot_batch_scoring/__init__.py | 2 +- datarobot_batch_scoring/main.py | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/CHANGES.rst b/CHANGES.rst index d4b4ef51..1a33faa2 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -1,3 +1,7 @@ +1.10.2 (2017 May 9) +================ +* Set default timeout on server response to infinity. + 1.10.1 (2017 April 27) ================ diff --git a/datarobot_batch_scoring/__init__.py b/datarobot_batch_scoring/__init__.py index ff987d28..2474f682 100644 --- a/datarobot_batch_scoring/__init__.py +++ b/datarobot_batch_scoring/__init__.py @@ -1 +1 @@ -__version__ = '1.10.1' +__version__ = '1.10.2' diff --git a/datarobot_batch_scoring/main.py b/datarobot_batch_scoring/main.py index 6689525d..44174465 100644 --- a/datarobot_batch_scoring/main.py +++ b/datarobot_batch_scoring/main.py @@ -106,7 +106,7 @@ def parse_args(argv, standalone=False): conn_gr = parser.add_argument_group('Connection control') conn_gr.add_argument('--timeout', type=int, - default=30, + default=None, help='The timeout for each post request. ' '(default: %(default)r)') conn_gr.add_argument('--n_samples', type=int,