You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The client package currently uses zerolog for logging. While this is a good library, people are now switching to https://github.com/go-logr/ which decouples the logging interface from the implementing library, à la SLF4J. Also, logr is widely used in the Kubernetes space.
We should then switch the client package to logr.
I am still on the fence about adding log calls to the other packages as they are meant for use in the hot path of a driver and any penalty incurred by log calls, even minimal, should be imo avoided.
The text was updated successfully, but these errors were encountered:
The client package currently uses zerolog for logging. While this is a good library, people are now switching to https://github.com/go-logr/ which decouples the logging interface from the implementing library, à la SLF4J. Also, logr is widely used in the Kubernetes space.
We should then switch the client package to logr.
I am still on the fence about adding log calls to the other packages as they are meant for use in the hot path of a driver and any penalty incurred by log calls, even minimal, should be imo avoided.
The text was updated successfully, but these errors were encountered: