Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from zerolog to logr #24

Open
adutra opened this issue Aug 31, 2021 · 0 comments
Open

Switch from zerolog to logr #24

adutra opened this issue Aug 31, 2021 · 0 comments

Comments

@adutra
Copy link
Contributor

adutra commented Aug 31, 2021

The client package currently uses zerolog for logging. While this is a good library, people are now switching to https://github.com/go-logr/ which decouples the logging interface from the implementing library, à la SLF4J. Also, logr is widely used in the Kubernetes space.

We should then switch the client package to logr.

I am still on the fence about adding log calls to the other packages as they are meant for use in the hot path of a driver and any penalty incurred by log calls, even minimal, should be imo avoided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant