Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ckanext.cloudstorage.connection_link not documented in README #5

Open
JVickery-TBS opened this issue Oct 3, 2022 · 1 comment
Open

Comments

@JVickery-TBS
Copy link

ckanext.cloudstorage.connection_link usage in https://github.com/datopian/ckanext-cloudstorage/blob/master/ckanext/cloudstorage/storage.py#L162 was merged but the config option was not documented in the README.

Not sure what I am supposed to set this to?

The property is used in azure.storage.blob.BlobServiceClient.from_connection_string() calls. Would be good to link https://learn.microsoft.com/en-us/python/api/azure-storage-blob/azure.storage.blob.blobserviceclient?view=azure-python#azure-storage-blob-blobserviceclient-from-connection-string

as well as specify all of the options from the azure-storage-blob library:

  • AccountName
  • AccountKey
  • SharedAccessSignature
  • endpoints (primary, and secondary)
  • DefaultEndpointsProtocol
  • EndpointSuffix
@JVickery-TBS
Copy link
Author

Perhaps a fair option would be to modify connection_link property definition to just use the already loaded driver_options:

@property
    def connection_link(self):
        """
        The connection link to the container
        """
        return "AccountName={};AccountKey={}".format(
            self.driver_options['key'],
            self.driver_options['secret']
        )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant