Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getParsedHeader returns quoted "components" with the quotes included #6

Open
elbow opened this issue Oct 4, 2017 · 1 comment
Open

Comments

@elbow
Copy link

elbow commented Oct 4, 2017

Hi Dave,

req.getParsedHeader('Authorization') returns like so:

[2017-10-04T10:18:16.290Z] DEBUG (3468 on steve-xps-eos): Authorization header
authorization: [
{
"scheme": "Digest",
"username": ""9123c799-e4dc-4dd5-ae11-3b7e35df57d0"",
"realm": ""fibrephone.co.za"",
"nonce": ""VbkBPUJl4rAGa5fwSzuS6ffhOH98LpFh"",
"uri": ""sip:[email protected]:6060;transport=TCP"",
"response": ""84d4b16e1e8898b70fe5f45bac381acb"",
"cnonce": ""5e385c0f4224a7332acb25753ce41452"",
"nc": "00000001",
"qop": "auth",
"algorithm": "MD5"
}
]

It doesn't seem very useful for me that the returned components contain embedded quotes?

Perhaps it creates a backward compatibility problem to change it, but it would be handier if they were just used as delimiters and not returned in the result?

Thanks,
Steve

@davehorton
Copy link
Owner

agree it would be nice. Will look into making this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants