fixing split tags and fixing nil pointer deference (#115)

davidji99 · Nov 3, 2022 · 0a7885f · 0a7885f
1 parent f4f97c4
commit 0a7885f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/api/api.go b/api/api.go
@@ -140,8 +140,8 @@ func (c *Client) setHeaders() {
 }
 
 func (c *Client) checkRateLimit(resp *simpleresty.Response) bool {
-	if resp.StatusCode == 429 {
-		remainingOrgSeconds, _ := strconv.Atoi(resp.Resp.Header().Get("X-RateLimit-Reset-Seconds-Org"))
+	if resp != nil && resp.StatusCode == 429 {
+		remainingOrgSeconds, _ := strconv.Atoi((resp.Resp.Header().Get("X-RateLimit-Reset-Seconds-Org")))
 		timeToSleep, _ := strconv.Atoi(resp.Resp.Header().Get("X-RateLimit-Reset-Seconds-IP"))
 		if remainingOrgSeconds != 0 {
 			// Got rate-limit by Organization

diff --git a/api/split.go b/api/split.go
@@ -18,7 +18,7 @@ type Split struct {
 	ID                     *string             `json:"id"`
 	Name                   *string             `json:"name"`
 	Description            *string             `json:"description"`
-	Tags                   []string            `json:"tags,omitempty"`
+	Tags                   []SplitTag          `json:"tags,omitempty"`
 	CreationTime           *int64              `json:"creationTime"`
 	RolloutStatusTimestamp *int64              `json:"rolloutStatusTimestamp"`
 	TrafficType            *TrafficType        `json:"trafficType"`
@@ -48,6 +48,11 @@ type SplitUpdateRequest struct {
 	Description string `json:"description"`
 }
 
+// SplitTag represents a tag in the split
+type SplitTag struct {
+	Name string `json:"name"`
+}
+
 // List all splits.
 //
 // Reference: https://docs.split.io/reference/list-splits