Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Coaches Poll rankings to NCAAF #7

Open
smitsam555 opened this issue Jun 8, 2024 · 3 comments · May be fixed by #8
Open

Add Coaches Poll rankings to NCAAF #7

smitsam555 opened this issue Jun 8, 2024 · 3 comments · May be fixed by #8

Comments

@smitsam555
Copy link

Is your feature request related to a problem? Please describe.
Users should be able to pull the Coaches Poll rankings from the ncaaf.rankings module for each college football season, along with the AP and CFP rankings which are currently supported. The Coaches Poll has a level of popularity and prominence near that of the AP and CFP rankings, and therefore is likely to be desired by many users. If implemented, the ncaaf.rankings module would then support all three college football rankings available on sports-reference.com. These rankings should function similarly to the AP and CFP rankings which are already available.

Describe the solution you'd like
The rankings should be incorporated with the ncaaf.rankings module and be requested and structured similarly to how the AP and CFP rankings are currently handled. As the AP and CFP rankings are provided through separate classes, a third class for the Coaches poll would need to be added.

Describe alternatives you've considered
An alternative to pulling these three rankings using three near-duplicate classes would be to refactor the current code to construct one Rankings class and then have each of three classes for the separate polls inherit from it. Each of these subclasses would just need to use their own respective URLs and perhaps some unique HTML tags. This change would take more work up front, but may be easier to maintain down the road.

Additional context
A link to the 2023 Coaches poll can be found here

@smitsam555
Copy link
Author

I have been working on this feature and have it nearly ready to go. I was going to add it to the original repository until I noticed that it has gone dormant. Let me know if you would like this feature added here to your fork and I can start a pull request.

@smitsam555 smitsam555 reopened this Jun 8, 2024
@smitsam555
Copy link
Author

Apologies for my clumsy clicking, this issue is still open.

@davidjkrause
Copy link
Owner

Sure, happy to add this if you have the changes ready

@smitsam555 smitsam555 linked a pull request Jun 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants