Add Coaches Poll rankings to NCAAF #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NCAAF rankings functionality currently supports two of the three ranking types available on sports-reference.com. This change adds support for the third ranking type, the USA Today Coaches Poll. This commit includes testing for the new feature, as well as corrects a few minor docstring errors in the rankings.py file. Signed-off-by: Samuel Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NCAAF rankings functionality currently supports two of the three ranking types available on sports-reference.com. This change adds support for the third ranking type, the USA Today Coaches Poll. This commit includes testing for the new feature, as well as corrects a few minor docstring errors in the rankings.py file.
Signed-Off By: Samuel Smith [email protected]
closes #7