Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The insert overwrite does this, so let's copy that pattern here to keep the schemas/datasets tidy in BQ for the users
resolves ##1389
Problem
When using a
merge
strategy with the model checking the schema (To add or replace columns):There is nothing to delete the temp table created:
Solution
We add in a step to delete and tidy up the temporary table, in the same way that is currently there for the
insert_overwrite
strategy:I also checked that there was no impact on the 'ignore' strategy for
on_schema_change
:There is no temporary table made here so we do not expect the DROP statement to appear:
Checklist
I ran
tox -p
and everything seems to passThis change does change a macro but i'm unsure how to get feedback for Product or DX