[Epic] state:modified should Actually (only) select the modified resources

[graciegoheen]

We currently call out a lot of caveats to state comparison in our docs.

There are many scenarios where executing dbt list --select state:modified over or under selects the appropriate resources. This leads to:

• confusion "why are these models selected as state:modified, I haven't changed them"
• performance concerns "why am I running 60 models when I only changed 2"
• potentially bad code sneaking it's way into production "i checked my changes using a Slim CI job, but these models weren't run, now production is broken"

While it's unlikely we can cover ever single edge case here, we should improve state:modified so that it Ideally actually only selects the modified resources.

This epic will track the relevant bugs/enhancements related to state:modified.

p0

Beta Give feedback

1. [state:modified] Introduce tests to capture current state of env-aware configuration and state:modified #10002
   state +1
   
2. [Bug] semantic models always included as part of state:modified #9548
   backport 1.7.latest bug +2
   
3. [Spike+][jinja if statement] [false positives] environment-aware logic in config should not cause resources to always be selected by state:modified #9563
   enhancement state state: modified +3
   
4. [macro] [false positives] environment-aware logic in config should not cause resources to always be selected by state:modified #9564
   enhancement state state: modified +3
5. [Bug] saved queries are always selected as "modified", they should not be #10138
   +0
   
6. [env_vars] [false positives] environment-aware logic for sources should not cause sources to always be marked as modified #9573
   enhancement state state: modified +3
   

p1

Beta Give feedback

1. [vars] [false negatives] Changes in used variables do not cause models to be selected by state:modified #4304
   paper_cut state state: modified +3
2. [CT-3166] [Bug] State modified --select state:modified ignores new sources #8727
   Refinement bug state: modified +3

[matt-winkler]

What would be lost by disallowing env-aware logic outside the dbt_project.yml?

[patkearns10]

Lots of examples here: https://discourse.getdbt.com/t/why-are-ci-jobs-state-method-building-more-less-models-nodes-than-expected/7504
An example of env_var logic here , which seems impossible to keep out of state:modified

[graciegoheen]

For those following along, would love to hear your thoughts over in this discussion #10518

[graciegoheen]

Closing this EPIC since we wrapped the issues that will be going out in 1.9 - queued up the remaining issues for 1.10

[FishtownBuildBot]

Opened a new issue in dbt-labs/docs.getdbt.com: dbt-labs/docs.getdbt.com#6538