You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Basically, our current invalid directory of unit tests is insufficiently smart - it will fail if a single schema item is invalid, so if we accidentally add something that is valid while believing it to be invalid, we won't be warned.
As far as I can tell, the best thing we can do to properly validate is to compare the outputs of the --all-errors flag in ajv-cli against a source-controlled list of expected errors which we'll need to manually update as we add new failing tests.
Open to alternative approaches
The text was updated successfully, but these errors were encountered:
Follow on from the thread at #117 (comment)
Basically, our current
invalid
directory of unit tests is insufficiently smart - it will fail if a single schema item is invalid, so if we accidentally add something that is valid while believing it to be invalid, we won't be warned.As far as I can tell, the best thing we can do to properly validate is to compare the outputs of the
--all-errors
flag in ajv-cli against a source-controlled list of expected errors which we'll need to manually update as we add new failing tests.Open to alternative approaches
The text was updated successfully, but these errors were encountered: