Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reference to the repo to schemastore #3

Open
joellabes opened this issue Aug 18, 2022 · 1 comment
Open

Add reference to the repo to schemastore #3

joellabes opened this issue Aug 18, 2022 · 1 comment

Comments

@joellabes
Copy link
Collaborator

Context:

https://github.com/SchemaStore/schemastore/blob/master/CONTRIBUTING.md

Schemata can be hosted directly on schemastore, or they can be stored in a separate repository with schemastore providing a reference to the raw file.

Upload to schemastore directly

Pros:

  • Allows refs to work across files (only possible on local files)
  • We can upload positive and negative test files to validate the validator, without building our own

Keep files in this repo and just set up a reference in schemastore

Pros:

  • Single source of truth
  • We have control over PR flow and can rapidly iterate if needed
  • Versioning is tidier - we can point old versions to a tagged commit instead of having an entire different copy of the file (compare for example agripparc-1.2.json, agripparc-1.3.json, agripparc-1.4.json)
@joellabes
Copy link
Collaborator Author

I think that we should keep the files here and just hotlink to the repo:

  • The files are pretty static, so a bit of repetition in the refs doesn't seem like the end of the world
  • Nice versioning and ease of releasing changes feels more important to me

@joellabes joellabes changed the title Decide whether to upload files to schemastore directly or hotlink to this repo Add reference to the repo to schemastore Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant