Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Rename method to authenticator #955

Open
3 tasks done
VersusFacit opened this issue Nov 22, 2024 · 0 comments
Open
3 tasks done

[Feature] Rename method to authenticator #955

VersusFacit opened this issue Nov 22, 2024 · 0 comments
Labels
enhancement New feature or request triage

Comments

@VersusFacit
Copy link
Contributor

VersusFacit commented Nov 22, 2024

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt-redshift functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Recently, in an internal discussion we referred to dbt-redshift's authenticator config param. We then realized that the param is called method on that adapter. Let's align the two names by migrating the param with use of a behavior flag to derisk.

The work in dbt-redshift will be to rename the parameter in the Credentials class and all referencing tests.

Describe alternatives you've considered

Leave it as is

Who will this benefit?

In a multi-platform workflow, having a standard configuration nameset leads to a more intuitive (and satisfying) user experience. This PR continues our tend of standardizing name fields across adapters.

Are you interested in contributing this feature?

of course

Anything else?

We will need to consider how this affects Cloud profile generation. It may not. But there's a minor chance it might and we should be conscious of that possibility.

This will require a docs update as well.

@VersusFacit VersusFacit added enhancement New feature or request triage labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage
Projects
None yet
Development

No branches or pull requests

1 participant