Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix materialized view label #6370

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Fix materialized view label #6370

merged 3 commits into from
Nov 20, 2024

Conversation

skion
Copy link
Contributor

@skion skion commented Oct 28, 2024

What are you changing in this pull request and why?

The materialized view materialization is named materialized_view in snake case, not materialized view, at least for the Postgres adapter. The docs didn't reflect this.

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • The content in this PR requires a dbt release note, so I added one to the release notes page.
  • Check whether this is also true for adapters other than Postgres.

@skion skion requested a review from a team as a code owner October 28, 2024 11:55
Copy link

vercel bot commented Oct 28, 2024

@skion is attempting to deploy a commit to the dbt-labs Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Oct 28, 2024
Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Nov 20, 2024 5:22pm

@runleonarun
Copy link
Collaborator

Great catch @skion! And thank you for creating a PR to fix it. I will get this merged!

Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@runleonarun runleonarun enabled auto-merge (squash) November 20, 2024 16:59
@runleonarun runleonarun disabled auto-merge November 20, 2024 17:18
@runleonarun runleonarun merged commit 00ddfc2 into dbt-labs:current Nov 20, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants