add env var link #6424
Merged
add env var link #6424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this pr adds a link to the env var doc.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
nataliefiann
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Hiya @mirnawong1
Thanks for creating this. I have no suggested changes for this but as a non-blocker suggestion, would it be worthwhile adding a small sentence (ref Andrew mentioning) "Else you can also keep the flag off if you discover implementation breakage and maybe open up an issue in the dbt core repo?"
Kind Regards
Natalie
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr adds a link to the env var doc raised in internal slack.
We can also add clarifying language o it has more guidance on how to test and enable microbatch with existing custom logic.
🚀 Deployment available! Here are the direct links to the updated files: