Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add links to microbatch configs #6616

Merged
merged 3 commits into from
Dec 9, 2024
Merged

add links to microbatch configs #6616

merged 3 commits into from
Dec 9, 2024

Conversation

@mirnawong1 mirnawong1 requested a review from a team as a code owner December 9, 2024 10:21
Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Dec 9, 2024 11:10am

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address Docs team Authored by the Docs team @dbt Labs labels Dec 9, 2024
@mirnawong1 mirnawong1 enabled auto-merge December 9, 2024 10:21
@mirnawong1 mirnawong1 disabled auto-merge December 9, 2024 10:21
Copy link
Contributor

@nataliefiann nataliefiann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @mirnawong1

Thanks for creating this. I've approved this for you.
I have a non-blocking suggestion - with the "Available in dbt Core v1.9+ or the dbt Cloud "Latest" release tracks." (this could be a side project - I'd be happy to pick this up, should we make this a callout as in the concurrent_batches doc - attached)?

Kind Regards
Natalie
Screenshot 2024-12-09 at 10 59 08

@mirnawong1
Copy link
Contributor Author

Hiya @mirnawong1

Thanks for creating this. I've approved this for you. I have a non-blocking suggestion - with the "Available in dbt Core v1.9+ or the dbt Cloud "Latest" release tracks." (this could be a side project - I'd be happy to pick this up, should we make this a callout as in the concurrent_batches doc - attached)?

Kind Regards Natalie Screenshot 2024-12-09 at 10 59 08

thanks @nataliefiann ! yea i think based on our last discussion in our docs triage meeting last week, we mentioned i’m going to look into making this into a global code snippet so all version callouts are consistent with language.

i believe i was going to take this on so happy to work with you if you’d like to.

@mirnawong1 mirnawong1 merged commit 4ebafab into current Dec 9, 2024
9 checks passed
@mirnawong1 mirnawong1 deleted the add-config-links branch December 9, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants